Consolidate loop and sandbox patterns with completion signal enhancement#2
Merged
chriswritescode-dev merged 9 commits intomainfrom Apr 6, 2026
Merged
Consolidate loop and sandbox patterns with completion signal enhancement#2chriswritescode-dev merged 9 commits intomainfrom
chriswritescode-dev merged 9 commits intomainfrom
Conversation
- Add LOOP_PERMISSION_RULESET for consistent permission handling - Improve sandbox timeout handling with hard deadlines - Add git common dir detection for worktree mounts - Remove opencode.jsonc workaround - Clean up strip-promise-tags utility
…ed after 3 iterations
- src/index.ts:89: Use config.sandbox?.mode === 'docker' directly instead of isSandboxEnabled(config, null) which always returned false since sandboxManager was not yet created at init time - src/services/loop.ts:138-143: Revert checkCompletionSignal to simple case-insensitive includes() matching. The <promise> tag wrapping was introduced in the refactor but never wired into agent instructions, causing loops to run indefinitely - test/loop.test.ts: Update test cases to use raw signal strings and add case-insensitive test - src/tools/loop.ts: Import DEFAULT_COMPLETION_SIGNAL from services instead of duplicating, and use isSandboxEnabled() consistently in restart - src/tui.tsx:210: Sync inlined completion instructions with canonical version - src/utils/loop-helpers.ts: Remove unused formatElapsed function All 329 tests pass. TypeScript and type checking pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes