Use --config-dir parameter for dmf-get configuration extraction#54
Closed
Use --config-dir parameter for dmf-get configuration extraction#54
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect usage of dmf-get config
Clean module binaries from config directory after dmf-get extraction
Feb 8, 2026
JohnAmadis
reviewed
Feb 8, 2026
modules/CMakeLists.txt
Outdated
| COMMAND ${DMF_GET} -d "${DMBOOT_MODULES_DMD}" -o "${DMBOOT_CONFIGS_TEMP_DIR}" -t "${DMOD_TOOLS_NAME}" --cpu-family "${DMBOOT_MCU_SERIES}" -y --type dmfc | ||
| COMMAND ${CMAKE_COMMAND} -E echo "Copying configuration files to ${DMBOOT_CONFIG_DIR}..." | ||
| COMMAND ${CMAKE_COMMAND} -E copy_directory "${DMBOOT_CONFIGS_TEMP_DIR}" "${DMBOOT_CONFIG_DIR}" | ||
| COMMAND ${CMAKE_COMMAND} -E echo "Removing module files (.dmf, .dmd, .dmp) from config directory..." |
Contributor
There was a problem hiding this comment.
@copilot jakie removing?! dmf-get sam instaluje poprawnie pliki konfiguracyjne, ktore sa podane do sciezki ktora podasz jako --config-dir - nic wiecej nie potrzeba. Nie wiem co ty tu odwalasz
Contributor
Author
There was a problem hiding this comment.
You're absolutely right! The issue was using -o instead of --config-dir. Changed to use --config-dir parameter which properly installs only config files without intermediates. Fixed in a2ec801.
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
Clean module binaries from config directory after dmf-get extraction
Use --config-dir parameter for dmf-get configuration extraction
Feb 8, 2026
JohnAmadis
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build/configsdirectory was being polluted with module binaries (.dmf, .dmd, .dmp) when it should contain only configuration files for the dmffs filesystem. The root cause was using the wrongdmf-getparameter.Changes
dmf-getparameter from-o(output directory) to--config-dirwhen extracting configuration files from DMDRoot Cause
The original code used
-o(output directory) which is a general parameter that may create intermediate module files during processing. The--config-dirparameter is specifically designed for configuration file installation and ensures only configuration files are placed in the target directory.Result
Config directory now contains only the clean hierarchy:
Module binaries remain properly isolated in
build/dmf/.This matches the expected behavior shown in the issue example using
dmf-get dmclk --config board/stm32f746g-disco.ini --config-dir /tmp/config.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.