Skip to content

Fix misleading error when opening device file as directory #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAmadis merged 2 commits into from
Feb 11, 2026
Merged

Fix misleading error when opening device file as directory #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527ee83
Initial plan
Copilot Feb 11, 2026
374bca9
Fix file listing - distinguish file from directory in opendir error
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/dmdevfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,15 @@ dmod_dmfsi_dif_api_declaration( 1.0, dmdevfs, int, _opendir, (dmfsi_context_t ct

if (!is_directory(ctx, path))
{
// Check if the path is a file (device node)
driver_node_t* driver_node = find_driver_node(ctx, path);
if (driver_node != NULL)
{
// Path exists but is a file, not a directory
DMOD_LOG_ERROR("Not a directory: %s\n", path);
return DMFSI_ERR_NOT_FOUND;
}
// Path doesn't exist at all
DMOD_LOG_ERROR("Directory not found: %s\n", path);
return DMFSI_ERR_NOT_FOUND;
}
Expand Down