feat(schedule): add my-vote filter chips#206
Open
chiptus wants to merge 4 commits into
Open
Conversation
Adds Must Go / Interested / Won't Go chips (OR-ed, URL-persisted) next to the Filters trigger on both Timeline and List, filtering sets through the shared filterScheduleDays predicate keyed to the viewer's own votes. Hidden entirely when logged out; selection counts toward the filter badge. Closes #196 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AziTqr3f12fxALYD6jhrW8
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
A shared ?votes= link no longer dead-ends logged-out visitors: without a viewer identity the vote predicate passes every set and the filter badge skips the vote count. Malformed vote entries in the URL are dropped individually instead of discarding the whole selection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AziTqr3f12fxALYD6jhrW8
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AziTqr3f12fxALYD6jhrW8
…o claude/188-196-my-vote-chips # Conflicts: # src/hooks/useTimelineUrlState.ts # src/lib/searchSchemas.ts # src/pages/EditionView/tabs/ScheduleTab/horizontal/TimelineToolbar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Must Go / Interested / Won't Go chips to the Schedule filters, letting the viewer filter both Timeline and List to sets they voted on themselves.
Selection is OR-ed, persists in the URL, and counts toward the filter badge.
Closes #196. Stacked on the #195 filter-sheet branch/PR - review only the top commit if that PR is still open.
Verification
pnpm run lint,pnpm run typecheck,pnpm vitest runall pass.Generated by Claude Code