feat(timeline): add now pill and time indicator#204
Open
chiptus wants to merge 5 commits into
Open
Conversation
Adds a Now pill in the day-jump toolbar and a dashed current-time indicator on the Timeline strip, both rendered only while now (festival timezone) falls inside the rendered timeline's festival window. Extends resolveTimelineMountMoment's precedence with a now-1h rule (scrollTo -> day filter -> now-1h inside window -> festival start), backed by a new isNowWithinFestivalWindow pure function and a useNow(60s) hook that is the sole place `new Date()` is read for this feature. Closes #194
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… into claude/188-194-now-indicator
Active stage/time filters shrank TimelineData's bounds and hid the Now pill mid-festival; the pill and the mount now-rule are now gated on a new calculateScheduleWindow(scheduleDays) computed from the unfiltered schedule, while the indicator stays gated on the rendered strip's own bounds. Also clamps the mount now-rule to max(now - 1h, window start) so a now within the window's first hour can't resolve before it opens.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AziTqr3f12fxALYD6jhrW8
… into claude/188-194-now-indicator # Conflicts: # src/hooks/useTimelineScrollSync.ts # src/pages/EditionView/tabs/ScheduleTab/horizontal/Timeline.tsx # src/pages/EditionView/tabs/ScheduleTab/horizontal/TimelineContainer.tsx # src/pages/EditionView/tabs/ScheduleTab/horizontal/TimelineToolbar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Now pill in the day-jump toolbar and a dashed current-time indicator on the Timeline strip, both present only while now (festival timezone) falls inside the festival window. Mount precedence now includes a now−1h rule between the day filter and the festival-start fallback.
Closes #194. Stacked on #193 (day-jump toolbar) - base branch is
claude/188-193-day-jump-toolbar, notmain.Verification
supabase/seed.sql, "test"/"2025"): Timeline opens near now minus ~1h, the Now pill renders in the toolbar, and the dashed indicator sits at the right offset on the strip.scrollTois written to the URL and the strip smooth-scrolls to center on now; the viewport never auto-scrolls on its own as the indicator ticks.pnpm run lint,pnpm run typecheck, andpnpm vitest runall pass.src/lib/timelineMountMoment.test.ts(now-1h precedence rule,isNowWithinFestivalWindowboundaries). New e2e spec:tests/e2e/timeline-now-indicator.spec.ts(controlled clock viapage.clock.setFixedTime; not run locally, no local Supabase in this environment).Generated by Claude Code