Skip to content

Log unservicable response errors on HTTPServer#825

Open
avinashkamat48-design wants to merge 2 commits into
cherrypy:mainfrom
avinashkamat48-design:codex/serve-unservicable-error-log
Open

Log unservicable response errors on HTTPServer#825
avinashkamat48-design wants to merge 2 commits into
cherrypy:mainfrom
avinashkamat48-design:codex/serve-unservicable-error-log

Conversation

@avinashkamat48-design

Copy link
Copy Markdown

Summary

  • replace the invalid self.server.error_log call in HTTPServer._serve_unservicable()
  • add a focused regression test for exceptions raised while sending the polite 503 response

Verification

  • python -m pytest cheroot/test/test_server.py::test_serve_unservicable_logs_simple_response_errors -q (test passed; command exited nonzero because single-test coverage is below the repo-wide fail-under threshold)
  • git diff --check

Closes #797

@read-the-docs-community

read-the-docs-community Bot commented Jun 11, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.28%. Comparing base (2ffb0ba) to head (a8a068b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   78.32%   78.28%   -0.04%     
==========================================
  Files          41       41              
  Lines        4788     4817      +29     
  Branches      547      547              
==========================================
+ Hits         3750     3771      +21     
- Misses        900      907       +7     
- Partials      138      139       +1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace self.server.error_log() with self.error_log() in HTTPServer._serve_unservicable()

1 participant