Skip to content

tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported.#810

Merged
webknjaz merged 2 commits into
cherrypy:mainfrom
mr-c:ci/py3.14.0-final
Feb 9, 2026
Merged

tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported.#810
webknjaz merged 2 commits into
cherrypy:mainfrom
mr-c:ci/py3.14.0-final

Conversation

@mr-c

@mr-c mr-c commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Works towards: #767

For the Debian package of cheroot we need Python 3.14 support, and I noticed modifying and adapting the Python3.13 specific warning for Python 3.14 was enough to get the tests to pass with Python 3.14.

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

#767

📋 Other information:

📋 Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@codecov

codecov Bot commented Jan 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@51b7d62). Learn more about missing BASE report.
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage        ?   78.19%           
=======================================
  Files           ?       41           
  Lines           ?     4788           
  Branches        ?      547           
=======================================
  Hits            ?     3744           
  Misses          ?      905           
  Partials        ?      139           

@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 8216c94 to 449c60e Compare January 8, 2026 10:45
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided A mark meaning that a new change log entry is present within the patch. label Jan 8, 2026
@mr-c

mr-c commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author
  • cheroot/test/test_ssl.py::test_tls_client_auth is flaky with Python 3.14, so I copied the existing filter warning
    ignore:Exception ignored in. <function IOBase.__del__:pytest.PytestUnraisableExceptionWarning

    and adapted it to the Python 3.14 syntax
  • I don't know why the doc builds are failing; perhaps that is unrelated?

@mr-c mr-c force-pushed the ci/py3.14.0-final branch 3 times, most recently from d2fe6f9 to 8f28fd9 Compare January 8, 2026 11:43
@mr-c mr-c marked this pull request as draft January 8, 2026 11:48
@mr-c mr-c changed the title Mark Python 3.14 as being officially supported. tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported. Jan 8, 2026
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 8f28fd9 to 04c6ad1 Compare January 8, 2026 11:56
@mr-c mr-c marked this pull request as ready for review January 8, 2026 11:58
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 04c6ad1 to 372d3e0 Compare January 9, 2026 14:44
@mr-c

mr-c commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

Doc failures are fixed in #811 ; I can include those here, if desired

Comment thread docs/changelog-fragments.d/767.contrib.rst Outdated
Comment thread .github/workflows/ci-cd.yml
Comment thread pytest.ini
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 372d3e0 to 87e4b81 Compare February 9, 2026 16:10
Comment thread .github/workflows/ci-cd.yml Outdated
Comment thread .github/workflows/pip-tools.yml
Comment thread docs/changelog-fragments.d/767.packaging.rst
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 87e4b81 to 00fdb16 Compare February 9, 2026 16:21
Comment thread docs/changelog-fragments.d/767.contrib.rst
@mr-c mr-c force-pushed the ci/py3.14.0-final branch 2 times, most recently from a79bc82 to 4db9158 Compare February 9, 2026 17:17
@webknjaz

webknjaz commented Feb 9, 2026

Copy link
Copy Markdown
Member

Fixes: #767

Not sure if we should be closing that issue with this. It's probably best to keep it open for the follow-up fixes since this PR only suppresses warnings that do need fixing at some point.

@mr-c mr-c force-pushed the ci/py3.14.0-final branch from d1e8e61 to e4374f5 Compare February 9, 2026 17:26
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from e4374f5 to cef5c0a Compare February 9, 2026 17:29
mr-c and others added 2 commits February 9, 2026 19:37
The existing Python 3.13 filterwarning is copied and adapted for the
Python 3.14 syntax
Now that the silence warning issue is fixed.

See also: cherrypy#767
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from cef5c0a to 88a494a Compare February 9, 2026 18:37
@github-project-automation github-project-automation Bot moved this from 🧐 @webknjaz's review queue 📋 to ⏰ Merge reminder needed 🔀 in 📅 Procrastinating in public 😵‍💫 Feb 9, 2026
@webknjaz webknjaz merged commit 4bb134f into cherrypy:main Feb 9, 2026
65 of 123 checks passed
@github-project-automation github-project-automation Bot moved this from ⏰ Merge reminder needed 🔀 to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫 Feb 9, 2026
@mr-c mr-c deleted the ci/py3.14.0-final branch February 9, 2026 18:45
julianz- pushed a commit to julianz-/cheroot that referenced this pull request Feb 25, 2026
tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported.
julianz- pushed a commit to julianz-/cheroot that referenced this pull request Feb 25, 2026
tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported.
julianz- pushed a commit to julianz-/cheroot that referenced this pull request Feb 25, 2026
tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided A mark meaning that a new change log entry is present within the patch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants