Skip to content

fix: avoid structuredClone on spectrum data - #4293

Open
tpoisseau wants to merge 1 commit into
mainfrom
avoid-structured-clone-on-data
Open

fix: avoid structuredClone on spectrum data#4293
tpoisseau wants to merge 1 commit into
mainfrom
avoid-structured-clone-on-data

Conversation

@tpoisseau

Copy link
Copy Markdown
Contributor

It can crash on big datasets (>500Mo)

@tpoisseau
tpoisseau marked this pull request as ready for review July 31, 2026 14:41
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 31, 2026

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: f93cd5d
Status: ✅  Deploy successful!
Preview URL: https://f7a73a6b.nmrium.pages.dev
Branch Preview URL: https://avoid-structured-clone-on-da.nmrium.pages.dev

View logs

It can crash on big datasets (>500Mo)
@tpoisseau
tpoisseau force-pushed the avoid-structured-clone-on-data branch from f565035 to f93cd5d Compare July 31, 2026 14:44
@tpoisseau
tpoisseau requested a review from targos July 31, 2026 14:46
@tpoisseau

Copy link
Copy Markdown
Contributor Author

Loading kDrive/Projects/NMRium/test_data/huge/HSQC_16k_4k.zip (720Mo) works in chrome now (even if it is really slow 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant