Skip to content

fix: set a safe min contour level to avoid crashes #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jobo322 merged 2 commits into from
Jan 27, 2026
Merged

fix: set a safe min contour level to avoid crashes #3926

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5e8a9e
fix: set a safe min contour level to avoid crashes
jobo322 Jan 27, 2026
ebd8326
fix: adjust default contour levels to prevent crashes
jobo322 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/data/data2d/Spectrum2D/contours.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ function getDefaultContoursLevel(spectrum: Spectrum2D, quadrant = 'rr') {
const minAllowed = 3 * xMaxAbsoluteValue([positive, negative]);

const minLevel = Math.max(minAbsPeakBase, minAllowed);
const minContourLevel = calculateValueOfLevel(minLevel, max, true);
const minContourLevel = Math.min(
calculateValueOfLevel(minLevel, max, true),
90,
Comment thread
jobo322 marked this conversation as resolved.
Outdated
);

const defaultLevel: ContourOptions = {
negative: {
Expand Down
Loading