Skip to content

Conversation

@tpoisseau
Copy link
Contributor

  • remove save to json / json in zip options

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2026

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 757dddc
Status: ✅  Deploy successful!
Preview URL: https://3996ec7c.nmrium.pages.dev
Branch Preview URL: https://561-deprecate-older-nmrium-f.nmrium.pages.dev

View logs

@tpoisseau
Copy link
Contributor Author

I can't reproduce error from https://github.com/cheminfo/nmrium/actions/runs/21173563769/job/60897499181?pr=3915 in my local environment.

I'm up to date with main. npm ci to be sure to have correct deps installed. No error with npx playwright test --project chromium...

@targos
Copy link
Member

targos commented Jan 20, 2026

Tests are flaky on github. I restarted the run.

@tpoisseau
Copy link
Contributor Author

Tests are flaky on github. I restarted the run.

I did it some times, I'm glad this time is OK 😅

@tpoisseau tpoisseau marked this pull request as draft January 21, 2026 10:04
@tpoisseau
Copy link
Contributor Author

Draft to disable CI, need changes from core to works.

@tpoisseau
Copy link
Contributor Author

Wait for a fix in core

@lpatiny
Copy link
Member

lpatiny commented Jan 26, 2026

We found out with Hamed that the issue

image

Is not there if first we unzip the .nmrium.zip file or if we are using Firefox.

@tpoisseau
Copy link
Contributor Author

tpoisseau commented Jan 26, 2026

As for opening it unzipped, I'm not surprised that it works correctly (but it doesn't preserve the preferences/changes contained in the archive).
However, I am surprised that it works when opened with Firefox. I use Zen (a derivative of Firefox) and I have this problem when opening the nmrium archive.

I don't know if the issue is in the nmrium archive serializer, nmrium archive reader, or in nmrium state reducer. Nmrium state management is complex and we need help to understand why the view of this specific spectra is broken when reads from an nmrium archive.

@hamed-musallam hamed-musallam force-pushed the 561-deprecate-older-nmrium-file-formats branch from c87202b to 05924f5 Compare January 26, 2026 09:55
@tpoisseau
Copy link
Contributor Author

tpoisseau commented Jan 26, 2026

Hello @hamed-musallam you force pushed on this branch and lost some commits (it seems you rebased the branch).

I created a new one from previous head of this branch: https://github.com/cheminfo/nmrium/compare/refs-pr-3915 (We need theses commits attached to a branch to use nmrium as submodule in an other repository).

I let you cherry-pick:

It should solves CI errors ;-)

@lpatiny lpatiny marked this pull request as ready for review January 26, 2026 13:48
@lpatiny lpatiny merged commit eb2cf49 into main Jan 26, 2026
12 checks passed
@lpatiny lpatiny deleted the 561-deprecate-older-nmrium-file-formats branch January 26, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants