-
Notifications
You must be signed in to change notification settings - Fork 33
feat: save to NMRium Archive v1 format #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tpoisseau
commented
Jan 20, 2026
- remove save to json / json in zip options
Deploying nmrium with
|
| Latest commit: |
757dddc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3996ec7c.nmrium.pages.dev |
| Branch Preview URL: | https://561-deprecate-older-nmrium-f.nmrium.pages.dev |
|
I can't reproduce error from https://github.com/cheminfo/nmrium/actions/runs/21173563769/job/60897499181?pr=3915 in my local environment. I'm up to date with main. |
|
Tests are flaky on github. I restarted the run. |
I did it some times, I'm glad this time is OK 😅 |
|
Draft to disable CI, need changes from core to works. |
src/component/1d-2d/components/FloatMoleculeStructures/FloatMolecules.tsx
Outdated
Show resolved
Hide resolved
|
Wait for a fix in core |
|
As for opening it unzipped, I'm not surprised that it works correctly (but it doesn't preserve the preferences/changes contained in the archive). I don't know if the issue is in the nmrium archive serializer, nmrium archive reader, or in nmrium state reducer. Nmrium state management is complex and we need help to understand why the view of this specific spectra is broken when reads from an nmrium archive. |
* remove save to json / json in zip options
fix: don't throw on missing molecules
c87202b to
05924f5
Compare
|
Hello @hamed-musallam you force pushed on this branch and lost some commits (it seems you rebased the branch). I created a new one from previous head of this branch: https://github.com/cheminfo/nmrium/compare/refs-pr-3915 (We need theses commits attached to a branch to use nmrium as submodule in an other repository). I let you cherry-pick:
It should solves CI errors ;-) |
