Open
Conversation
…ent functionality and its edge cases
…pdateCardholder parameters order swap
Payment setups responses now derive from resource
… IdentityVerification + unit tests, must verify
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…N serialization pattern already existing using Gson
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved handling of request serialization and adds support for new identity-related API clients. The most significant update is the refactoring of the transport layer to support both JSON and form-encoded requests, making it more flexible for different content types. Additionally, several new clients for identity verification and screening have been integrated into the main API interface.
Transport layer improvements
ApacheHttpClientTransportto accept anObjectas the request payload, allowing both JSON andUrlEncodedFormEntityform-encoded requests. Added logic to serialize objects to JSON or pass form entities directly, and set the appropriateContent-Typeheader. (src/main/java/com/checkout/ApacheHttpClientTransport.java) [1] [2] [3]ApiClientImplmethods to pass raw request objects to the transport layer instead of pre-serializing them, aligning with the new transport interface. (src/main/java/com/checkout/ApiClientImpl.java) [1] [2] [3] [4]Identity API client integration
FaceAuthenticationClient,ApplicantClient,IdentityVerificationClient,IdDocumentVerificationClient,AmlScreeningClient) toCheckoutApiandCheckoutApiImpl, including their instantiation and interface methods. (src/main/java/com/checkout/CheckoutApi.java,src/main/java/com/checkout/CheckoutApiImpl.java) [1] [2] [3] [4] [5] [6]Supporting changes
GsonSerializer.javato support form-encoded serialization, includingUrlEncodedFormEntityand related classes. (src/main/java/com/checkout/GsonSerializer.java) [1] [2]These changes enhance the SDK's flexibility for handling different request types and expand its functionality for identity verification workflows.