Skip to content

Support agentic test session cancellation#1354

Merged
thebiglabasky merged 1 commit into
mainfrom
herve/agentic-session-cancel-cli
Jun 19, 2026
Merged

Support agentic test session cancellation#1354
thebiglabasky merged 1 commit into
mainfrom
herve/agentic-session-cancel-cli

Conversation

@thebiglabasky

Copy link
Copy Markdown
Contributor

Summary

  • centralize test-session cancellation wiring for checkly test, checkly trigger, and checkly pw-test
  • keep cancellation test-session scoped so the backend resolves cancellable result types instead of the CLI sending sequence IDs
  • add coverage for local and triggered Agentic checks carrying the test session/sequence IDs needed by the shared cancel path

Backend dependency

Verification

  • pnpm install
  • pnpm pack from packages/cli
  • pnpm run lint -- packages/cli/src/services/test-session-cancel.ts packages/cli/src/services/__tests__/test-session-cancel.spec.ts packages/cli/src/services/__tests__/test-session-runners.spec.ts packages/cli/src/commands/test.ts packages/cli/src/commands/trigger.ts packages/cli/src/commands/pw-test.ts
  • pnpm exec vitest run --silent=true ./src/services/__tests__/test-session-cancel.spec.ts ./src/services/__tests__/test-session-runners.spec.ts ./src/services/__tests__/abstract-check-runner.spec.ts ./src/rest/__tests__/cancel.spec.ts from packages/cli
  • pnpm run prepare:dist from packages/cli

@thebiglabasky thebiglabasky marked this pull request as ready for review June 18, 2026 15:20
@thebiglabasky thebiglabasky requested review from hwartig and sorccu June 18, 2026 23:41
if (!testSessionId) return
await api.cancel.cancelTestSession({ testSessionId })
})
registerTestSessionCancelHandler(runner, reporters)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that reads much better now 👏

@thebiglabasky thebiglabasky merged commit 025fbcc into main Jun 19, 2026
37 of 43 checks passed
@thebiglabasky thebiglabasky deleted the herve/agentic-session-cancel-cli branch June 19, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants