Skip to content

[DO NOT MERGE] Build CheCode editor image to test PR-363#769

Open
vrubezhny wants to merge 2 commits into
che-incubator:mainfrom
vrubezhny:test/che-machine-exec-PR-363
Open

[DO NOT MERGE] Build CheCode editor image to test PR-363#769
vrubezhny wants to merge 2 commits into
che-incubator:mainfrom
vrubezhny:test/che-machine-exec-PR-363

Conversation

@vrubezhny

@vrubezhny vrubezhny commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Opened to create a CheCode editor image to test:

eclipse-che/che-machine-exec#363

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Summary by CodeRabbit

  • Bug Fixes
    • Improved startup and initialization of the machine execution service.
    • Added support for machine execution binaries across UBI 8, UBI 9, and musl environments.
    • Updated shared runtime volume setup to include the required CheCode components.
    • Improved execution reliability by starting the service from its correct runtime location.

RomanNikitenko and others added 2 commits July 8, 2026 14:25
…ainers

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Opened to create a CheCode editor image to test:

- eclipse-che/che-machine-exec#363

<!-- Please include any related issue from the Eclipse Che repository (or from another issue tracker). -->

- [ ] the PR contains changes in the [code](https://github.com/che-incubator/che-code/tree/main/code) folder (you can skip it if your changes are placed in a che extension )
- [ ] the corresponding items were added to the [CHANGELOG.md](https://github.com/che-incubator/che-code/blob/main/.rebase/CHANGELOG.md) file
- [ ] rules for automatic `git rebase` were added to the [.rebase](https://github.com/che-incubator/che-code/tree/main/.rebase) folder

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

* **Chores**
  * Updated the container image used during the build assembly process to a newer version, which may improve build reliability and consistency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Click here to review and test in web IDE: Contribute

@tolusha

tolusha commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant check-pr-test-failures — Analyze failing CI checks, identify root causes, and suggest fixes
  • /che-ai-assistant update-che-e2e-tests — Update Eclipse Che e2e tests
  • /che-ai-assistant claude — Run a free-form instruction on this PR
  • /che-ai-assistant help — Show this help message

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f0cf958b-d37a-496e-980e-b8ddcc4c40e4

📥 Commits

Reviewing files that changed from the base of the PR and between d2d7be6 and 7acccdf.

📒 Files selected for processing (3)
  • build/dockerfiles/assembly.Dockerfile
  • build/scripts/entrypoint-init-container.sh
  • build/scripts/entrypoint-volume.sh
💤 Files with no reviewable changes (1)
  • build/scripts/entrypoint-init-container.sh

📝 Walkthrough

Walkthrough

The machine-exec assembly now uses a PR-specific image and packages separate binaries for ubi8, ubi9, and musl under their respective checode directories. Initialization copies all /checode-* directories into the shared /checode/ volume. The volume entrypoint starts ./machine-exec later in execution with MACHINE_EXEC_PORT=3333, replacing the earlier /checode/bin/machine-exec launch.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MachineExecImage
  participant RootfsAssembly
  participant InitContainer
  participant ChecodeVolume
  participant VolumeEntrypoint
  participant MachineExec

  MachineExecImage->>RootfsAssembly: Supply che-machine-exec binaries
  RootfsAssembly->>ChecodeVolume: Populate distribution-specific checode directories
  InitContainer->>ChecodeVolume: Copy /checode-* content into /checode/
  VolumeEntrypoint->>MachineExec: Start ./machine-exec with MACHINE_EXEC_PORT=3333
  MachineExec->>ChecodeVolume: Run from the selected checode directory
Loading

Suggested reviewers: azatsarynnyy, rgrunber, vitaliy-guliy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise, imperative, and clearly describes building a CheCode editor image to test PR-363.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Rebase Rules For Upstream Changes ✅ Passed HEAD only changes build/dockerfiles/assembly.Dockerfile; no files under code/ (excluding che extensions/locks) were modified, so no rebase rules/changelog are required.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants