Remove unused Twemoji CDN URLs from CSP configuration#1681
Closed
Remove unused Twemoji CDN URLs from CSP configuration#1681
Conversation
* Initial plan * feat: Add reCAPTCHA URLs to frameSrcUrls for iframe support Co-authored-by: eleanorreem <16049515+eleanorreem@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: eleanorreem <16049515+eleanorreem@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The cdnjs.cloudflare.com/twemoji URLs were not needed because: - The app uses the 'gemoji' npm package which provides Unicode emoji characters - No actual Twemoji image CDN is being used in the codebase - Emojis are rendered as Unicode characters, not loaded as images This addresses the reviewer's concern about the overly narrow URL pattern. Co-authored-by: eleanorreem <16049515+eleanorreem@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on CSP URLs for 2FA implementation
Remove unused Twemoji CDN URLs from CSP configuration
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes did you make and why did you make them?
Removed
https://cdnjs.cloudflare.com/ajax/libs/twemoji/from CSPimgSrcUrlsandconnectSrcUrlsarrays inscriptUrls.js.The URLs were unnecessary because:
gemojinpm package which provides Unicode emoji charactersnameToEmoji[name]inlib/utils/richText.tsx, not as CDN-loaded imagesAddresses reviewer feedback about overly narrow URL pattern by removing unused URLs rather than broadening them—minimizes CSP attack surface.
Did you run tests? Share screenshot of results:
How did you find us? (GitHub, Google search, social media, etc.):
N/A - addressing review feedback on PR #1678
Before submitting, check that you have completed the following tasks:
After submitting, please be available for discussion. Thank you!
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.