fix: get_draft possibly returning non-draft msg - #8532
Open
WofWca wants to merge 1 commit into
Open
Conversation
WofWca
force-pushed
the
wofwca/fix-get-draft-race
branch
from
August 2, 2026 16:03
2bda9b7 to
a19ac2f
Compare
WofWca
force-pushed
the
wofwca/fix-get-draft-race
branch
5 times, most recently
from
August 2, 2026 16:25
d9cae15 to
8de62f2
Compare
WofWca
marked this pull request as ready for review
August 2, 2026 16:28
WofWca
force-pushed
the
wofwca/fix-get-draft-race
branch
from
August 2, 2026 19:10
8de62f2 to
ab6dbe0
Compare
Due to a gap between `get_draft_msg_id()` and `Message::load_from_db`. Possibly can happen if the draft gets sent while `get_draft()` is in progress. Solved by doing both queries in a transaction.
WofWca
force-pushed
the
wofwca/fix-get-draft-race
branch
from
August 2, 2026 19:31
ab6dbe0 to
c1a8fc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a gap between
get_draft_msg_id()andMessage::load_from_db.Possibly can happen if the draft gets sent
while
get_draft()is in progress.Solved by doing both queries in a transaction.