[don't merge] Demo for showing wild cancellation disrupting multi-device multi-relay sync - #8512
Closed
hpk42 wants to merge 4 commits into
Closed
[don't merge] Demo for showing wild cancellation disrupting multi-device multi-relay sync#8512hpk42 wants to merge 4 commits into
hpk42 wants to merge 4 commits into
Conversation
Without the fix, too fast transport changes are ignored at the receiver side.
…essage Uncaching only after send_sync_transports() could send the sync message from the old primary address, so other devices never switched.
hpk42
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to showcase the failure that #8499 fixes.
I pushed two branches that each add the same
test_wild_cancel.pyrpc client test and a sleep of 0.01ms afterexecute_sync_itemsreturns.FAILS reliably (also here on the PR branch): hpk/show-wild-cancel branching off fix various transport multi-device de-synchronizinzation issues #8499 except for the last async-cancel shift commit
hpk-wild-cancel-fail.txt
PASSES reliably: hpk/show-wild-cancel-fixed branching off the full fix various transport multi-device de-synchronizinzation issues #8499, so including the async-cancel-shift commit
hpk-wild-cancel-fixed-ok.txt