Skip to content

feat: allow clients to specify whether a call has video initially or not#7740

Merged
Amzd merged 16 commits intomainfrom
amzd/has_video_initially
Feb 4, 2026
Merged

feat: allow clients to specify whether a call has video initially or not#7740
Amzd merged 16 commits intomainfrom
amzd/has_video_initially

Conversation

@Amzd
Copy link
Collaborator

@Amzd Amzd commented Jan 17, 2026

Couple of questions:

  • Do I need to make cffi and rpc place_outgoing_call function backwards compatible?
  • Is it ok to add headers the way I did?

@Amzd Amzd requested review from link2xt and r10s January 17, 2026 14:59
@Amzd Amzd changed the title Amzd/has video initially feat: allow clients to specify whether a call has video initially or not Jan 17, 2026
@Amzd Amzd force-pushed the amzd/has_video_initially branch 2 times, most recently from e219ab5 to 5b0454f Compare January 30, 2026 14:38
@Amzd Amzd force-pushed the amzd/has_video_initially branch from 5b0454f to c3aba61 Compare January 30, 2026 14:44
@Amzd Amzd marked this pull request as ready for review January 31, 2026 13:22
@iequidoo iequidoo self-requested a review February 1, 2026 14:42
@iequidoo
Copy link
Collaborator

iequidoo commented Feb 2, 2026

Do I need to make cffi and rpc place_outgoing_call function backwards compatible?

Not sure here however. Let's wait for someone else's approval. The only thing i can say is that for testing Desktop backward compatibility is convenient -- no need to rebuild Desktop, but only Core.

@WofWca
Copy link
Collaborator

WofWca commented Feb 2, 2026

Do I need to make cffi and rpc place_outgoing_call function backwards compatible?

On Desktop specifically we're fine with not having backwards-compatibility. But maybe some bot developers would like that, IDK.
I think the way to do this is to define a new function, and keep the old one's signature as is. Thankfully it's just 3 lines long.

@Amzd
Copy link
Collaborator Author

Amzd commented Feb 4, 2026

maybe some bot developers would like that

Afaik bots are not placing calls, so I will keep it simple like this.

Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks sane at a glance.
Did not test.

About the more high-level stuff, such as the introduction of a new param I am not sure.

This reverts mistake in commit 8ebaac8.
@Amzd Amzd enabled auto-merge (squash) February 4, 2026 16:31
@Amzd Amzd merged commit 63bf4c4 into main Feb 4, 2026
55 of 56 checks passed
@Amzd Amzd deleted the amzd/has_video_initially branch February 4, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants