Persist task bids in API route#4
Open
xcapselx wants to merge 2 commits into
Open
Conversation
b6597d8 to
85ada2a
Compare
Author
|
Small follow-up commit added: the bid route now only records the bid in memory after the Supabase Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This persists task bids created by
POST /api/tasks/:id/bidthrough the existingpersist(...)helper.The route currently writes bids to the in-memory store and returns
201, but the bid may not be durable across later task-detail reads. Nearby routes, such as agent registration, already callpersist(...)after updating the in-memory store.Change
submitted_atonce.bidstable before returning success.Why
A successful bid response should mean the task owner and later
GET /api/tasks/:idreads can see the bid. If the bid only lands in memory, agents may believe they submitted successfully while the task page does not show the bid.Validation
git diff --check -- src/web/src/app/api/[...path]/route.tspassed.tsc --noEmitis currently blocked by unrelated pre-existing syntax errors insrc/mcp-server/arena/games/generated/pillar-27.ts.