Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
PR Complexity Score: 2.0 - Simple
View Breakdown
- Lines Changed: 58
- Files Changed: 5
- Complexity Added: 3
- Raw Score: 20.66
High-level summary
This PR releases version 3.19.1 with a focused bug fix in HTTP URL construction. It ensures that URLs are built without a trailing ? when there are no query parameters, while still correctly preserving existing query strings. Version metadata and tests are updated accordingly.
Key functionalities and changes
- Fixes URL construction in
chargebee.http_request.request:- Avoids appending a trailing
?when there is no query string. - Preserves existing query strings when present.
- Avoids appending a trailing
- Updates package version from
3.19.0to3.19.1in bothVERSIONandchargebee/version.py. - Adds and updates tests to validate:
- No trailing
?for URLs without query parameters. - Correct handling of URLs that already contain a query string.
- Adjusts existing test expectation for subdomain URL (no trailing
?).
- No trailing
- Documents the bug fix in
CHANGELOG.mdunder v3.19.1.
File-level change summary
| File | Change summary |
|---|---|
CHANGELOG.md |
Adds v3.19.1 entry describing the bug fix for URL construction (no trailing ? when no query params). |
VERSION |
Bumps version from 3.19.0 to 3.19.1. |
chargebee/http_request.py |
Refactors URL construction: builds a base URL and conditionally appends ?{meta.query} only when meta.query is non-empty, preventing trailing ?. |
chargebee/version.py |
Updates VERSION constant from "3.19.0" to "3.19.1". |
tests/test_http_request.py |
Updates existing subdomain URL test to expect no trailing ?, and adds two new tests to ensure URLs without query params don’t end with ? and that existing query strings are preserved without adding a bare trailing ?. |
cb-srinaths
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.19.1 (2026-03-11)
Bug Fixes:
?when there are no query parameters.