Skip to content

Releasing v3.19.1#121

Merged
cb-alish merged 1 commit intomasterfrom
release-v3.19.1
Mar 11, 2026
Merged

Releasing v3.19.1#121
cb-alish merged 1 commit intomasterfrom
release-v3.19.1

Conversation

@cb-alish
Copy link
Collaborator

v3.19.1 (2026-03-11)


Bug Fixes:

  • Fixed URL construction to avoid appending a trailing ? when there are no query parameters.

@cb-alish cb-alish requested a review from cb-srinaths March 11, 2026 04:51
@snyk-io
Copy link

snyk-io bot commented Mar 11, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@hivel-marco hivel-marco bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Complexity Score: 2.0 - Simple

View Breakdown
  • Lines Changed: 58
  • Files Changed: 5
  • Complexity Added: 3
  • Raw Score: 20.66

High-level summary

This PR releases version 3.19.1 with a focused bug fix in HTTP URL construction. It ensures that URLs are built without a trailing ? when there are no query parameters, while still correctly preserving existing query strings. Version metadata and tests are updated accordingly.

Key functionalities and changes

  • Fixes URL construction in chargebee.http_request.request:
    • Avoids appending a trailing ? when there is no query string.
    • Preserves existing query strings when present.
  • Updates package version from 3.19.0 to 3.19.1 in both VERSION and chargebee/version.py.
  • Adds and updates tests to validate:
    • No trailing ? for URLs without query parameters.
    • Correct handling of URLs that already contain a query string.
    • Adjusts existing test expectation for subdomain URL (no trailing ?).
  • Documents the bug fix in CHANGELOG.md under v3.19.1.

File-level change summary

File Change summary
CHANGELOG.md Adds v3.19.1 entry describing the bug fix for URL construction (no trailing ? when no query params).
VERSION Bumps version from 3.19.0 to 3.19.1.
chargebee/http_request.py Refactors URL construction: builds a base URL and conditionally appends ?{meta.query} only when meta.query is non-empty, preventing trailing ?.
chargebee/version.py Updates VERSION constant from "3.19.0" to "3.19.1".
tests/test_http_request.py Updates existing subdomain URL test to expect no trailing ?, and adds two new tests to ensure URLs without query params don’t end with ? and that existing query strings are preserved without adding a bare trailing ?.

@cb-alish cb-alish merged commit 5835793 into master Mar 11, 2026
3 checks passed
@cb-alish cb-alish deleted the release-v3.19.1 branch March 11, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants