Security: Authenticated arbitrary resource file read via mismatched resourceFileId#8728
Open
AngelFQC wants to merge 1 commit into
Open
Security: Authenticated arbitrary resource file read via mismatched resourceFileId#8728AngelFQC wants to merge 1 commit into
AngelFQC wants to merge 1 commit into
Conversation
…t-level ResourceFile read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/r/{tool}/{type}/{uuid}/viewhandler authorized the resource node in the path but returned the separateResourceFileselected by theresourceFileIdquery parameter without checking the file belonged to that node — an IDOR that let a low-privileged user read other users' files by numeric id. The handler now rejects (404) anyresourceFileIdwhose resource node does not match the path node. In addition, the individualGET /api/resource_files/{id}operation is tightened fromROLE_USERto object-levelis_granted('VIEW', object)(via the existingResourceFileVoter) to close the metadata/existence oracle.Note: the fix does not add a per-access-URL/tenant check for variants belonging to the same node (advisory remediation point 3); the primary cross-user/cross-course read is closed by the node-match check. Flagging the multi-URL variant nuance as a possible follow-up.
Refs GHSA-2prx-vqcv-mv68