Security: Unauthenticated arbitrary resource file deletion via delete_variant#8726
Open
AngelFQC wants to merge 1 commit into
Open
Security: Unauthenticated arbitrary resource file deletion via delete_variant#8726AngelFQC wants to merge 1 commit into
AngelFQC wants to merge 1 commit into
Conversation
…delete_variant endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds authorization to the
DELETE /r/resource_files/{id}/delete_variantendpoint, which previously deleted anyResourceFileby numeric id with no authentication or authorization. The handler now requiresEDITpermission on the owningResourceNode(admins pass viaROLE_ADMIN) and only allows removal of genuine access-URL variants (accessUrl !== null), returning 404 otherwise.Note: CSRF token validation was not added — the endpoint is consumed by the SPA over JWT bearer auth and adding a token would require a coordinated frontend change; the authorization check already eliminates the unauthenticated/cross-privilege vector. Flagging in case a CSRF layer is desired as defense-in-depth.
Refs GHSA-4j89-qjx2-3wcr