-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add --cashback flag to token launch + fix create_v2 accounts #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| """Tests for core/launch.py — cashback flag pass-through.""" | ||
|
|
||
| from unittest.mock import AsyncMock, patch | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_launch_passes_cashback_false(tmp_keystore): | ||
| """launch_token passes is_cashback=False through to build_create_instructions.""" | ||
| with ( | ||
| patch( | ||
| "pumpfun_cli.core.launch.upload_metadata", | ||
| new_callable=AsyncMock, | ||
| return_value="https://ipfs.example.com/metadata.json", | ||
| ), | ||
| patch("pumpfun_cli.core.launch.build_create_instructions", wraps=None) as mock_build, | ||
| patch("pumpfun_cli.core.launch.build_extend_account_instruction"), | ||
| patch( | ||
| "pumpfun_cli.core.launch.RpcClient", | ||
| ) as mock_rpc_cls, | ||
| ): | ||
| mock_client = AsyncMock() | ||
| mock_client.send_tx = AsyncMock(return_value="fakesig123") | ||
| mock_rpc_cls.return_value = mock_client | ||
|
|
||
| # build_create_instructions needs to return a list of instructions | ||
| from unittest.mock import MagicMock | ||
|
|
||
| mock_ix = MagicMock() | ||
| mock_build.return_value = [mock_ix] | ||
|
|
||
| from pumpfun_cli.core.launch import launch_token | ||
|
|
||
| result = await launch_token( | ||
| rpc_url="https://fake.rpc", | ||
| keystore_path=tmp_keystore, | ||
| password="testpass", | ||
| name="TestToken", | ||
| ticker="TST", | ||
| description="A test token", | ||
| is_cashback=False, | ||
| ) | ||
|
|
||
| mock_build.assert_called_once() | ||
| call_kwargs = mock_build.call_args | ||
| assert call_kwargs.kwargs.get("is_cashback") is False or ( | ||
| not call_kwargs.kwargs.get("is_cashback", True) | ||
| ) | ||
| assert result["is_cashback"] is False | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_launch_passes_cashback_true(tmp_keystore): | ||
| """launch_token passes is_cashback=True through to build_create_instructions.""" | ||
| with ( | ||
| patch( | ||
| "pumpfun_cli.core.launch.upload_metadata", | ||
| new_callable=AsyncMock, | ||
| return_value="https://ipfs.example.com/metadata.json", | ||
| ), | ||
| patch("pumpfun_cli.core.launch.build_create_instructions", wraps=None) as mock_build, | ||
| patch("pumpfun_cli.core.launch.build_extend_account_instruction"), | ||
| patch( | ||
| "pumpfun_cli.core.launch.RpcClient", | ||
| ) as mock_rpc_cls, | ||
| ): | ||
| mock_client = AsyncMock() | ||
| mock_client.send_tx = AsyncMock(return_value="fakesig456") | ||
| mock_rpc_cls.return_value = mock_client | ||
|
|
||
| from unittest.mock import MagicMock | ||
|
|
||
| mock_ix = MagicMock() | ||
| mock_build.return_value = [mock_ix] | ||
|
|
||
| from pumpfun_cli.core.launch import launch_token | ||
|
|
||
| result = await launch_token( | ||
| rpc_url="https://fake.rpc", | ||
| keystore_path=tmp_keystore, | ||
| password="testpass", | ||
| name="TestToken", | ||
| ticker="TST", | ||
| description="A test token", | ||
| is_cashback=True, | ||
| ) | ||
|
|
||
| mock_build.assert_called_once() | ||
| assert mock_build.call_args.kwargs["is_cashback"] is True | ||
| assert result["is_cashback"] is True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.