-
Notifications
You must be signed in to change notification settings - Fork 42
feat(user-verification): Introduce user verification on attestation init #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
migmartri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @javirln, see my comment about updating the annotations
|
Btw, this feature is awesome, lert's make sure we update our docs and changelog to reflect it |
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
This PR adds platform-based commit signature verification during attestation initialization. When creating an attestation, the system now queries GitHub or GitLab APIs to verify if the commit was signed and validated by the platform.
Extended the attestation initialization process to include commit signature verification status. The verification captures whether a commit's signature was validated by GitHub or GitLab, including details about the signature algorithm, key ID, and verification status.
Added new
VerifyCommitSignaturemethod to theSupportedRunnerinterface. Implemented verification for:GITHUB_TOKENCI_JOB_TOKENProtobuf Schema
Extended
Commitmessage with optionalplatform_verificationfield containing:Verification failures never block attestation creation. All errors result in recording the unavailable or not applicable status, allowing the attestation process to continue.
Example
Example from a GitHub Action. This is part of the crafting state:
Example of attestation: