Skip to content

Don't advertise federation host with empty SSH fingerprint #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 1 commit into from
Jul 7, 2026
Merged

Don't advertise federation host with empty SSH fingerprint #3183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cfe_internal/enterprise/federation/federation.cf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,9 @@ bundle agent setup_status
);

classes:
"ssh_server_fingerprint_collected"
expression => not(strcmp("$(ssh_server_fingerprint)", ""));

"superhub_setup_status_complete"
expression => "any",
depends_on => {
Expand All @@ -1219,7 +1222,12 @@ bundle agent setup_status
};

files:
superhub_setup_status_complete::
# An empty fingerprint (ssh-keyscan returned nothing, e.g. sshd not yet
# reachable on localhost) must not be advertised: a superhub would render
# an empty known_hosts entry for this host and its rsync pull would later
# fail with "Host key verification failed". Skip the status update until
# the fingerprint is collected; the next agent run will retry.
superhub_setup_status_complete.ssh_server_fingerprint_collected::
"$(cfengine_enterprise_federation:config.path_setup_status)"
create => "true",
perms => default:mog("600", "cfapache", "root"),
Expand All @@ -1233,6 +1241,10 @@ bundle agent setup_status
"transport_ssh_server_fingerprint": "$(ssh_server_fingerprint)",
}',
if => isvariable(ssh_pub_key);

reports:
superhub_setup_status_complete.!ssh_server_fingerprint_collected::
"warning: 'ssh-keyscan localhost' returned no SSH host key; federation setup status not written yet. Will retry next run.";
}

bundle agent distributed_cleanup_setup
Expand Down
Loading