CFE-3041: change regular acceptance test to .error.cf - #6334
Open
sarakthon wants to merge 1 commit into
Open
Conversation
|
Thank you for submitting a PR! Maybe @larsewi can review this? |
Ticket: CFE-3041
sarakthon
force-pushed
the
acceptance-tests
branch
from
August 26, 2026 13:58
5ef5489 to
45ee4a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand, this test deliberately causes an error considering it tries to insert lines to a file that does not exist. Based on this I think the test is a potential error.cf candidate.
Before change:
After adding a check to
testallthat flags tests which report "Pass", but still printerror:messages during execution, the following output was observed:The output in
error.logbefore changing the filename toerror.cfwas as follows:After change:
Output when running
testallafter changing filename toerror.cf:Output in
error.logafter changing filename toerror.cf: