CFE-4648: cf-execd SMTP port configurable#6064
Open
basvandervlies wants to merge 4 commits intocfengine:masterfrom
Open
CFE-4648: cf-execd SMTP port configurable#6064basvandervlies wants to merge 4 commits intocfengine:masterfrom
basvandervlies wants to merge 4 commits intocfengine:masterfrom
Conversation
CFE-4648: cf-execd SMTP port configurable
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsewi
reviewed
Mar 31, 2026
| exec_config->agent_expireafter = 2 * 60; /* two hours */ | ||
|
|
||
| exec_config->mail_server = xstrdup(""); | ||
| exec_config->mail_port = 25; |
Contributor
There was a problem hiding this comment.
Should it perhaps default to using the port returned from getservbyname("smtp", "tcp"), or does this always return 25?
Contributor
Author
There was a problem hiding this comment.
This is a well know service and it is always defined as25. Like ssh is always default 22and you can override it.
craigcomstock
approved these changes
Mar 31, 2026
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
seems reasonable, I do wonder if you shouldn't use the getservbyname() after all just to hedge bets that it couldn't possible be changed in the services database? It does seem prudent to prefer using the "API" as it were instead of hard-coding and assuming.
Squash the commits then good to go I'd say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFE-4648: cf-execd SMTP port configurable