Make expandrange able to output a single value #6034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (step_size < 1) | ||
| { | ||
| FatalError(ctx, "EXPANDRANGE Step size cannot be less than 1 or greater than the interval"); | ||
| Log(LOG_LEVEL_ERR, "%s: Step size cannot be less than 1", fp->name); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
- Allow ranges with a unique value (as the range is already inclusive) - Make invalid step value a soft fail Changelog: Allow expandrange to output a single value
amousset
force-pushed
the
allow-single-element-range
branch
from
db2ba4d to
de9375b
Compare
larsewi
approved these changes
Feb 10, 2026
| if (step_size < 1) | ||
| { | ||
| FatalError(ctx, "EXPANDRANGE Step size cannot be less than 1 or greater than the interval"); | ||
| assert(fp->name != NULL); |
Contributor
There was a problem hiding this comment.
I see you tried to fix the CodeQL issue. Can you change it to
assert(fp != NULL);and put it in the top of the function?
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13365/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13365/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: This avoids some special case handling when computing ranges where the bounds are equal (or lower than the step), with a consistent interface.