Fix Pytest using the wrong Python installation, add Pyright to legacy Python workflow, fix syntax errors on Python 3.5, remove Pyflakes#279
Merged
craigcomstock merged 10 commits intocfengine:masterfrom Sep 3, 2025
Conversation
pytest did not use the legacy Python version, instead using a local newer version Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Ticket: ENT-13212 Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Ticket: ENT-13212 Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
c2e51c5 to
aece23f
Compare
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
It appears to be redundant when already using flake8, and it seems to be impossible to ignore an incorrect error it generates. Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
larsewi
reviewed
Sep 3, 2025
larsewi
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that during legacy Python test workflows, Pytest did not use the virtual environment's legacy Python version: