CFE-4571: Even prettier cfbs pretty#278
Merged
olehermanse merged 9 commits intocfengine:masterfrom Aug 28, 2025
Merged
Conversation
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
not-pretty-enough-for-you
branch
from
1ca4256 to
ddfc6c6
Compare
larsewi
changed the title
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: CFE-4571 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: CFE-4571 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
not-pretty-enough-for-you
branch
2 times, most recently
from
fde0bca to
5faaacc
Compare
Ticket: CFE-4571 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
not-pretty-enough-for-you
branch
from
5faaacc to
2583839
Compare
We saw some cases where cfbs pretty and npm prettier did not agree. These tests prove that they now agree for those specific cases. Ticket: CFE-4571 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
not-pretty-enough-for-you
branch
from
2583839 to
d2a3e40
Compare
jakub-nt
approved these changes
Aug 28, 2025
olehermanse
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.