CFE-4537: Add shell unit testing of added_by field updating#233
Merged
olehermanse merged 1 commit intocfengine:masterfrom Jun 23, 2025
Merged
CFE-4537: Add shell unit testing of added_by field updating#233olehermanse merged 1 commit intocfengine:masterfrom
added_by field updating#233olehermanse merged 1 commit intocfengine:masterfrom
Conversation
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
This was referenced Jun 23, 2025
olehermanse
requested changes
Jun 23, 2025
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Test looks good, but the ticket number in the PR title is wrong.
jakub-nt
changed the title
added_by field updatingadded_by field updating
olehermanse
approved these changes
Jun 23, 2025
larsewi
reviewed
Jun 24, 2025
| cfbs --non-interactive init | ||
|
|
||
| # Ensure adding a module during initialization is treated as adding manually | ||
| cat cfbs.json | grep -F "added_by" | grep -F "cfbs init" |
Contributor
There was a problem hiding this comment.
In stead of cat cfbs.json | grep -F "added_by" you could do grep -F "added_by" cfbs.json. Just FYI, no need to change anything
Member
There was a problem hiding this comment.
Or grep -E "added_by|cfbs init" cfbs.json
Contributor
There was a problem hiding this comment.
^ would match added_by or cfbs init? But I think he wants to look for a line that contains added_by and this line should also contain cfbs init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.