fix: add allowedRoutes to Gateway HTTP listener in ListenerSet example#2193
Open
apkatsikas wants to merge 1 commit into
Open
fix: add allowedRoutes to Gateway HTTP listener in ListenerSet example#2193apkatsikas wants to merge 1 commit into
apkatsikas wants to merge 1 commit into
Conversation
Signed-off-by: apkatsikas <apkatsikas@gmail.com>
cert-manager-prow
Bot
added
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gateway HTTP listener in the ListenerSet example was missing allowedRoutes, which defaults to Same namespace. Without it, cert-manager's HTTP-01 challenge HTTPRoute (created in the application namespace) won't attach to the listener and the challenge will fail.