docs: rename tutorial 'Securing NGINX-ingress' to 'Securing ingress-nginx'#2188
Open
iacker wants to merge 1 commit into
Open
docs: rename tutorial 'Securing NGINX-ingress' to 'Securing ingress-nginx'#2188iacker wants to merge 1 commit into
iacker wants to merge 1 commit into
Conversation
…ginx' The tutorial uses ingress-nginx (kubernetes/ingress-nginx) but the title said 'NGINX-ingress', which is easily confused with the unrelated commercial NGINX Ingress Controller (nginx/kubernetes-ingress). Align the title, navigation manifest entry, and in-body references with the actual project name used throughout the tutorial. Closes cert-manager#1608 Signed-off-by: Billard <82095453+iacker@users.noreply.github.com>
cert-manager-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
size/XS
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the ACME tutorial "Securing NGINX-ingress" to "Securing ingress-nginx" to match the project actually used in the tutorial.
The tutorial installs and configures
ingress-nginx(the community Kubernetes project), but the page title said NGINX-ingress, which is easily confused with the unrelated commercial NGINX Ingress Controller maintained by F5/NGINX.This is a documentation-only, wording change. No logic, commands, or steps are modified.
Changes (current
content/docs/only — versioned snapshots left untouched):content/docs/tutorials/acme/nginx-ingress.md: frontmattertitle, intro sentence, and the "Step 2" heading aligned toingress-nginx.content/docs/manifest.json: navigation entry title updated to match.Validation
manifest.jsonre-validated as well-formed JSON locally (python3 -c "import json; json.load(...)").Step 2 - Deploy the NGINX Ingress Controllerheading anchor, so the heading rename breaks no cross-references.Closes #1608