Clarify ACME challenge scheduling behaviour#2097
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| The maximum number of challenges that can be processed at a time is 60 as of | ||
| [`ddff78`](https://github.com/cert-manager/cert-manager/blob/ddff78f011558e64186d61f7c693edced1496afa/pkg/controller/acmechallenges/scheduler/scheduler.go#L31-L33). No newline at end of file | ||
| This scheduler is a coarse back-pressure mechanism. It applies a cap on the |
There was a problem hiding this comment.
I have expanded this section because the corresponding code change in cert-manager/cert-manager#8781 is primarily documenting design intent rather than altering behaviour. The aim here is to make the same reasoning visible to documentation readers: the scheduler is intentionally conservative because a single cert-manager instance performs self-checks from one network and DNS viewpoint, and this is not the right layer to enforce multi-tenant isolation or DNS-name ownership policy.
e2c1f32 to
d41b2b0
Compare
Signed-off-by: Richard Wall <richard@the-moon.net>
What this PR does
Clarifies the ACME challenge scheduling documentation.
This updates the ACME concepts, configuration, and troubleshooting pages to explain that challenge scheduling is intentionally conservative, and that the scheduler should be understood as a coarse back-pressure mechanism rather than a fairness or policy layer.
Related to cert-manager/cert-manager#8781 and cert-manager/cert-manager#8643.
Why
The current documentation explains what the scheduler does, but not clearly why it behaves this way.
In particular, this PR adds context that:
It also adds cross-links from the ACME configuration and troubleshooting pages back to the concepts page, and to the policy documentation.