docs: replace node-markdown-spellcheck with cspell#2015
Open
IstvanCsVarga wants to merge 2 commits intocert-manager:masterfrom
Open
docs: replace node-markdown-spellcheck with cspell#2015IstvanCsVarga wants to merge 2 commits intocert-manager:masterfrom
IstvanCsVarga wants to merge 2 commits intocert-manager:masterfrom
Conversation
Replace the unmaintained markdown-spellcheck (mdspell) package with cspell, an actively maintained spell checker. The old tool has not been updated in over 6 years and is generating security alerts. Changes: - Swap markdown-spellcheck for cspell in devDependencies - Add cspell.json configuration with US English locale - Ignore historical versioned docs (content/v*-docs/**) - Ignore auto-generated API reference docs - Extend .spelling dictionary for cspell compatibility - Fix 14 genuine typos in current docs caught by cspell Closes cert-manager#1985 Signed-off-by: Istvan Csaba Varga <istvan.csaba.varga@accenture.com>
cert-manager-prow
bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/XXL
lodash/cloneDeep is used in lib/serialize.js but was previously only available as a transitive dependency of markdown-spellcheck. Adding it as a direct dependency so the build succeeds after the spellcheck tool swap. Signed-off-by: Istvan Csaba Varga <istvan.csaba.varga@accenture.com>
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Friendly ping — would appreciate a review when anyone has a chance. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the unmaintained node-markdown-spellcheck (mdspell) with cspell, an actively maintained spell checker. The old tool has not been updated in 6+ years and is generating security alerts (#1985).
Notes
Closes #1985