gateway.md: remove apiVersion and kind from ListenerSet conf example#2013
gateway.md: remove apiVersion and kind from ListenerSet conf example#2013maelvls wants to merge 4 commits intocert-manager:masterfrom
Conversation
These fields are automatically set by the Helm chart template, so users don't need to specify them manually. Addresses feedback from @ThatsMrTalbot in cert-manager#2001. Signed-off-by: Maël Valais <mael@vls.dev>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the Gateway API ListenerSet documentation to avoid requiring Helm users to manually set apiVersion/kind for the controller configuration, since these are templated by the Helm chart.
Changes:
- Remove
config.apiVersionandconfig.kindfrom the ListenerSetvalues.yamlexample. - Remove the corresponding
--set config.apiVersion=...and--set config.kind=...flags from the Helm install/upgrade example.
Comments suppressed due to low confidence (1)
content/docs/usage/gateway.md:526
- This ListenerSet Helm values example now omits
config.apiVersionandconfig.kind, but the earlier “enable Gateway API support” example in this same doc still includes them. To avoid confusing readers (and to justify why they’re missing here), add a short note near this snippet/command explaining that the Helm chart defaultsconfig.apiVersion/config.kindand they can be omitted, and consider aligning the earlier example to match.
```yaml
# values.yaml
config:
enableGatewayAPI: true
enableGatewayAPIListenerSet: true
featureGates:
ListenerSets: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cert-manager-bot <cert-manager-bot@users.noreply.github.com>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
|
ah, already done in #2011 😅 Closing. |
These fields are automatically set by the Helm chart template, so users don't need to specify them manually. Addresses feedback from @ThatsMrTalbot in #2001.