Skip to content

gateway.md: remove apiVersion and kind from ListenerSet conf example#2013

Closed
maelvls wants to merge 4 commits intocert-manager:masterfrom
maelvls:fix-listenerset-docs-feedback
Closed

gateway.md: remove apiVersion and kind from ListenerSet conf example#2013
maelvls wants to merge 4 commits intocert-manager:masterfrom
maelvls:fix-listenerset-docs-feedback

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Mar 12, 2026

These fields are automatically set by the Helm chart template, so users don't need to specify them manually. Addresses feedback from @ThatsMrTalbot in #2001.

These fields are automatically set by the Helm chart template, so users
don't need to specify them manually.

Addresses feedback from @ThatsMrTalbot in cert-manager#2001.

Signed-off-by: Maël Valais <mael@vls.dev>
Copilot AI review requested due to automatic review settings March 12, 2026 08:43
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Mar 12, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2026
@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ade6a6b
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/69b27d7460b4e10008e58a46
😎 Deploy Preview https://deploy-preview-2013--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Gateway API ListenerSet documentation to avoid requiring Helm users to manually set apiVersion/kind for the controller configuration, since these are templated by the Helm chart.

Changes:

  • Remove config.apiVersion and config.kind from the ListenerSet values.yaml example.
  • Remove the corresponding --set config.apiVersion=... and --set config.kind=... flags from the Helm install/upgrade example.
Comments suppressed due to low confidence (1)

content/docs/usage/gateway.md:526

  • This ListenerSet Helm values example now omits config.apiVersion and config.kind, but the earlier “enable Gateway API support” example in this same doc still includes them. To avoid confusing readers (and to justify why they’re missing here), add a short note near this snippet/command explaining that the Helm chart defaults config.apiVersion/config.kind and they can be omitted, and consider aligning the earlier example to match.
```yaml
# values.yaml
config:
  enableGatewayAPI: true
  enableGatewayAPIListenerSet: true
  featureGates:
    ListenerSets: true

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cert-manager-bot and others added 3 commits March 12, 2026 09:46
Signed-off-by: cert-manager-bot <cert-manager-bot@users.noreply.github.com>
Signed-off-by: Maël Valais <mael@vls.dev>
@cert-manager-prow cert-manager-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2026
@maelvls
Copy link
Member Author

maelvls commented Mar 12, 2026

ah, already done in #2011 😅 Closing.

@maelvls maelvls closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants