-
Notifications
You must be signed in to change notification settings - Fork 392
[CANCELLED] [release-next] Merge master into release-next #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f08bf18
f34c670
af6df60
9c4e19e
3bc0c77
09b6c4c
577c7af
f06c5c0
577e308
6bc3b91
d6b4a8f
e620400
276e4dc
9d4a628
296ace6
93be6b4
9259eeb
509fe3b
e91668b
f1e4a24
fd00b6c
0fcf995
c6234bd
d14e643
84730b3
9aab20c
6e2e711
212d573
adda23c
bdd8151
b92d967
9543c59
dc8d09a
bd14b8d
36d5cf6
1987864
8417d3b
b39bc64
ca5fb55
ab1d288
535af4d
318f88c
d68cb1b
ff3bdfb
fac0121
90dbb43
a064ca2
77308ce
abd909f
fffc0f1
38dc902
c5c58c2
6e438f4
b7ab240
e147990
d3b1da3
db2be10
71be766
ddd8ec7
a3075bb
550de1e
5971078
487cd4e
5e74086
bff28f5
747cc71
d0d3bd4
a9d8266
d1cdabc
a90091b
3d0c4b7
6a51446
b6e14a9
368d6dc
b0c07c5
5a6ad31
36b7e3e
80e6a8c
77bd6cd
8601612
4df1335
b6bc19d
2a9295d
86e4ba2
d9934e9
f23e737
7a9322a
ed67353
7542fb8
81bd27b
298a296
d9d273b
299935b
6795b02
16fcbd1
ee22dfd
aba3bd1
d496304
5fa3b77
4635794
f30a6c4
30a0f3f
4664c3c
3c4a0a3
2df648d
105b8cf
64af98a
da57168
823a656
6c733ef
d63cb8f
acae1ca
28f864b
70a0e03
8da7875
5b357b8
ee7911d
616997d
c68f211
0f85690
3b2826d
d457ce8
0e0dee1
a426964
1107cb6
ce34069
75ed7af
9e79d81
3f8b3f5
828601f
9a333ad
a824d17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,7 +29,7 @@ If you have an Azure AKS cluster you can use the following command: | |||||
| az aks update \ | ||||||
| --name ${CLUSTER} \ | ||||||
| --enable-oidc-issuer \ | ||||||
| --enable-workload-identity # ℹ️ This option is currently only available when using the aks-preview extension. | ||||||
| --enable-workload-identity | ||||||
| ``` | ||||||
|
|
||||||
| > ℹ️ You can [install the Azure workload identity extension on other managed and self-managed clusters](https://azure.github.io/azure-workload-identity/docs/installation.html) if you are not using Azure AKS. | ||||||
|
|
@@ -38,18 +38,15 @@ az aks update \ | |||||
| > | ||||||
| ### Reconfigure cert-manager | ||||||
|
|
||||||
| Label the cert-manager controller Pod and ServiceAccount for the attention of the Azure Workload Identity webhook, | ||||||
| Label the cert-manager controller Pod for the attention of the Azure Workload Identity webhook, | ||||||
| which will result in the cert-manager controller Pod having an extra volume containing a Kubernetes ServiceAccount token which it will use to authenticate with Azure. | ||||||
|
|
||||||
| If you installed cert-manager using Helm, the labels can be configured using Helm values: | ||||||
| If you installed cert-manager using Helm, the label can be configured using Helm values: | ||||||
|
|
||||||
| ```yaml | ||||||
| # values.yaml | ||||||
| podLabels: | ||||||
| azure.workload.identity/use: "true" | ||||||
| serviceAccount: | ||||||
| labels: | ||||||
| azure.workload.identity/use: "true" | ||||||
| ``` | ||||||
|
|
||||||
| If successful, the cert-manager Pod will have some new environment variables set, | ||||||
|
|
@@ -92,16 +89,17 @@ Choose a managed identity name and create the Managed Identity: | |||||
|
|
||||||
| ```bash | ||||||
| export IDENTITY_NAME=cert-manager | ||||||
| az identity create --name "${IDENTITY_NAME}" | ||||||
| export IDENTITY_RESOURCE_GROUP=<your-resource-group> # ❗ Replace with your Azure resource group | ||||||
|
||||||
| export IDENTITY_RESOURCE_GROUP=<your-resource-group> # ❗ Replace with your Azure resource group | |
| export IDENTITY_RESOURCE_GROUP=YOUR_RESOURCE_GROUP # ❗ Replace with your Azure resource group |
Copilot
AI
Mar 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in the YAML comments: # # optional: tenant ID .... This should likely be a single # comment marker to avoid confusing readers.
| # # optional: tenant ID of the managed identity; overrides AZURE_TENANT_ID from the environment. | |
| # optional: tenant ID of the managed identity; overrides AZURE_TENANT_ID from the environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This site is configured for static export (
output: 'export'innext.config.js). Usingnew Date().getFullYear()directly in the render output can cause hydration mismatches if the exported HTML was built in a different year than when a user visits (or if the build output is cached across New Year). Prefer injecting a build-time constant (e.g. via a prop or environment variable baked into the export) or keep the year static to avoid runtime divergence.