inspect secret: close response body on error path in CRL check#443
inspect secret: close response body on error path in CRL check#443wangwangbobo wants to merge 1 commit intocert-manager:mainfrom
Conversation
Fixes cert-manager#442 Added defer resp.Body.Close() immediately after http.Do() to ensure the response body is closed on all exit paths, not just the success path. This prevents TCP connection leaks when io.ReadAll fails.
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @wangwangbobo. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #442
Added defer resp.Body.Close() immediately after http.Do() to ensure the response body is closed on all exit paths, not just the success path. This prevents TCP connection leaks when io.ReadAll fails.