Open
Conversation
3120c92 to
7cf0883
Compare
Collaborator
|
Why are we using Maybe this is not the case @nathanielc ? |
Contributor
|
For technical reasons we were not able to expose both Kubo RPC and the Ceramic API on the same port. (They use different incompatible http frameworks) We can port Kubo RPC over to the framework Ceramic API uses but it wasn't a priority to start. |
Collaborator
|
Ok, thanks for the context @nathanielc. Seems like it might be worth to do that later when we want to migrate users to use rust-ceramic instead of kubo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds flag/config to support recon service api. Currently intended for testing/benchmarking env only (not backwards support, run with pubsub off, etc). Tries to minimize changes outside of recon service.
Add config
References:
Spec - https://www.notion.so/threebox/Recon-js-ceramic-3964bec706434050ad6a80653cea990a
Rust Ceramic - ceramicnetwork/rust-ceramic#60