s3: Add a test for attempting to complete an unstarted multipart upload#728
Open
jacquesh wants to merge 2 commits intoceph:masterfrom
Open
s3: Add a test for attempting to complete an unstarted multipart upload#728jacquesh wants to merge 2 commits intoceph:masterfrom
jacquesh wants to merge 2 commits intoceph:masterfrom
Conversation
The AWS documentation for CompleteMultipartUpload specifies that the call will return a 404 with the text "NoSuchUpload" to indicate that the specified multipart upload does not exist. This could be the result of an invalid upload ID or a multipart upload that has been aborted or completed. Of particular significance is the requirement that this API call return a 400-series error (indicating a client-side problem) and not a 500-series error (indicating a server-size problem). At the time of writing, Ceph returns a 500 in this scenario which may be handled incorrectly by client SDKs and is likely to be misinterpreted by Ceph monitoring as an increase in errors that require operator intervention to fix. CompleteMultipartUpload docs available at: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html Signed-off-by: Jacques Heunis <jheunis@bloomberg.net>
cbodley
reviewed
Apr 2, 2026
| assert status == 400 | ||
| assert error_code == 'MalformedXML' | ||
|
|
||
| @pytest.mark.fails_on_rgw # TODO: Remove fails_on_rgw when https://tracker.ceph.com/issues/75534 is fixed |
Contributor
There was a problem hiding this comment.
thanks very much for the test case. would you kindly remove this fails_on_rgw marker so i can use this to validate the fix in ceph/ceph#68186?
Signed-off-by: Jacques Heunis <jheunis@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS documentation for CompleteMultipartUpload specifies that the call will return a 404 with the text "NoSuchUpload" to indicate that the specified multipart upload does not exist. This could be the result of an invalid upload ID or a multipart upload that has been aborted or completed.
Of particular significance is the requirement that this API call return a 400-series error (indicating a client-side problem) and not a 500-series error (indicating a server-size problem).
At the time of writing, Ceph returns a 500 in this scenario which may be handled incorrectly by client SDKs and is likely to be misinterpreted by Ceph monitoring as an increase in errors that require operator intervention to fix.
Since this test currently fails, I've marked it as
fails_on_rgwand created a tracker for the issue.