Remove deprecated klog flags from csi-addons containers#444
Merged
Remove deprecated klog flags from csi-addons containers#444
Conversation
csi-addons has moved from klog to zap logging (see kubernetes-csi-addons#1006). The --logtostderr and --alsologtostderr flags are now accepted as no-ops in the sidecar. Remove these deprecated flags from the controller plugin and node plugin csi-addons container args. Signed-off-by: Praveen M <m.praveen@ibm.com>
Rakshith-R
approved these changes
Mar 23, 2026
Contributor
Author
|
This needs to be merged after we have a CSI-Addons release? |
Contributor
Author
|
/hold |
Madhu-1
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
csi-addons has moved from klog to zap logging (see kubernetes-csi-addons#1006).
The
--logtostderrand --alsologtostderrflags are now accepted as no-ops in the sidecar.Remove these deprecated flags from the controller plugin and node plugin csi-addons container args.
Checklist: