api: remove v1alpha1 resource definitions#420
Open
black-dragon74 wants to merge 2 commits intoceph:mainfrom
Open
api: remove v1alpha1 resource definitions#420black-dragon74 wants to merge 2 commits intoceph:mainfrom
black-dragon74 wants to merge 2 commits intoceph:mainfrom
Conversation
Member
Author
|
The tests are evaluating vendor files too, that shouldn't happen. |
Madhu-1
requested changes
Mar 4, 2026
Collaborator
Madhu-1
left a comment
Madhu-1
left a comment
There was a problem hiding this comment.
dont commit vendor to the api folder. there should be no changes/minimal changes to the vendor, these changes looks larger. PTAL
black-dragon74
force-pushed
the
rem-v1a1
branch
2 times, most recently
from
a635193 to
ec0719f
Compare
Member
Author
Whoops! Sorry, I vendored |
Madhu-1
reviewed
Mar 16, 2026
black-dragon74
force-pushed
the
rem-v1a1
branch
from
ec0719f to
a98bc6f
Compare
This patch removes the resource definitions for v1alpha1 APIs. They were deprecated with: ceph#218 Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
rem-v1a1
branch
from
a98bc6f to
822cb6f
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This patch removes the resource definitions for
v1alpha1APIs.They were deprecated with: #218