This repository was archived by the owner on Oct 3, 2023. It is now read-only.
update to grpc-gateway v2#223
Open
drewwells wants to merge 3 commits intocensus-instrumentation:masterfrom
Open
update to grpc-gateway v2#223drewwells wants to merge 3 commits intocensus-instrumentation:masterfrom
drewwells wants to merge 3 commits intocensus-instrumentation:masterfrom
Conversation
|
Thanks for looking at this! |
drewwells
commented
May 4, 2021
| local dest="$2" | ||
|
|
||
| if [[ -w $dest ]] | ||
| if [[ ! -w $(dirname $dest) ]] |
Author
There was a problem hiding this comment.
I had issues with this line calculating sudo correctly. I believe -w only evaluates valid paths. Since the destination does not exist, this always returned false. The result was sudo wget laid down a file as root:root and chmod below ran without sudo and was unable to change the file bits.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC Gateway went through a major rewrite to v2 last year. The main impact that I see on this repo is the protobuf annotation changes from swagger to openapiv2 and of course the protoc plugin was renamed as well. I'll take care of those in this PR.
Ref: https://grpc-ecosystem.github.io/grpc-gateway/docs/development/grpc-gateway_v2_migration_guide/