Audit fix: CGT vs Lockbox.#418
Merged
Mc01 merged 2 commits intocelo-contracts/v4.1.0from Feb 19, 2026
Merged
Conversation
pahor167
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
[M-01] OptimismPortal2#finalizeWithdrawalTransactionExternalProof - ETHLockbox Misaccounting With Custom Gas Token WithdrawalsNote
Medium Risk
Touches core deposit/withdrawal execution paths and configuration gating; mistakes could change lock/unlock behavior or break networks that rely on the lockbox feature.
Overview
Prevents ETHLockbox from being used on custom-gas-token (CGT) chains to avoid incorrect ETH accounting during deposits/withdrawals.
OptimismPortal2now treats lockbox as active only when the gas-paying token isConstants.ETHER,SystemConfig.setFeaturerejects enablingFeatures.ETH_LOCKBOXon CGT chains, andOPContractsManagerStandardValidatoradds corresponding validation (including asserting lockbox incompatibility with CGT). New tests cover the feature-flag revert and that deposits on CGT chains never callethLockbox.lockETHeven if the flag/storage are force-enabled.Written by Cursor Bugbot for commit 4b4d425. This will update automatically on new commits. Configure here.