Skip to content

Make cgf_diagnostics::teardown() a no-op instead of resetting the instance #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GagaLP wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make cgf_diagnostics::teardown() a no-op instead of resetting the instance #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/cgf_diagnostics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ class cgf_diagnostics {

static bool is_available() { return m_instance != nullptr; }

static void teardown() { m_instance.reset(); }
static void teardown() {
// Empty teardown function.
// If we ever need to do something specific for teardown in cfg_diagnostics
// we can use this function to do so.
}

static cgf_diagnostics& get_instance() {
assert(m_instance != nullptr);
Expand Down
Loading