fix(recall): normalize tool output to JSON-native at the safe_handler boundary (v3.24.1)#66
Merged
Merged
Conversation
… boundary The PostgreSQL store returns numpy.float32 scores and datetime timestamps where SQLite returns float/str. FastMCP can only build structuredContent from JSON-native values, so a non-native field dropped structuredContent and the host rejected recall with "outputSchema defined but no structured output returned" -- on PostgreSQL only, while SQLite-backed tests stayed green. Add shared/json_native.py::to_json_native (pure, stdlib-only, duck-typed numpy) applied at the tool_error_handler.safe_handler boundary every handler crosses, so all 43 tools return one JSON-native shape across backends. Regression tests are backend-agnostic (a fake PG-shaped handler) so CI fails regardless of which store the suite runs against. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mutation testing is the objective check that the test suite can detect a regression -- the recall bug shipped behind 100% green line coverage because no test asserted JSON-serializability and the suite ran on SQLite (native types), hiding the PostgreSQL-only failure. Add mutmut 3.x to the dev group, [tool.mutmut] config, and scripts/mutation_check.sh (scoped per-change runner that restores pyproject). Demonstrated on shared/json_native.py: first pass surfaced dead code (an unreachable .item() branch) and a test gap (invalid-utf8 bytes); after fixing both, only a proven-equivalent mutant survives. gitignore the mutants/ working dir. Bump 3.24.0 -> 3.24.1 (recall cross-backend fix). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The 3.24.0→3.24.1 bump (a83353d) updated pyproject/manifest.json/server.json but missed the two plugin manifests, reintroducing the exact version skew that 4b0994a previously fixed. The `version` field is the marketplace update signal: leaving it at 3.24.0 means Claude Code never offers the update to existing plugin/marketplace users, so the recall fix would not ship via the supported (git-tree) channel. All five manifests are now 3.24.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
recall(et les 42 autres outils MCP) échouait côté PostgreSQL uniquement avec :Le backend PG renvoie des types non-natifs (
numpy.float32,datetime) là où SQLite renvoiefloat/str. FastMCP ne sérialisait pas ces types → pas destructuredContentémis → rejet wire-level PG-only.Root cause & fix
Correction au choke point
safe_handler(mcp_server/tool_error_handler.py:144-181), pas par-store :to_json_native(result)est appliqué en sortie de chaque handler. Un seul point de normalisation → format de retour unique cross-backend pour les 43 outils.mcp_server/shared/json_native.py(NEW) —to_json_native, normaliseur pur stdlib / duck-typing (numpy, datetime, Decimal, etc.).mcp_server/tool_error_handler.py—safe_handlerapplique la normalisation.Vérification
numpy.float32/datetime, désormais natif).tests_py/shared/test_json_native.py(NEW) +tests_py/server/test_handler_contract.py::TestWireValuesAreJsonNative(régressions backend-agnostiques).Inclus aussi (commit
a83353d0)pyproject.toml [tool.mutmut],scripts/mutation_check.sh, standardcoding-standards.md §12, templatestryker.conf.json.pyproject.toml/manifest.json/server.json+ CHANGELOG.Post-merge (manuel, hors PR)
Republier PyPI
hypermnesia-mcp3.24.1 + plugin → re-sync copie installéecortex/3.24.x→ redémarrer la session. Tant que ce n'est pas fait,cortex:recallreste cassé côté PG dans les sessions en cours.🤖 Generated with Claude Code