Skip to content

refactor(wpConfigs): css-minimizer to minimizer-webpack-plugin #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cdcabrera wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(wpConfigs): css-minimizer to minimizer-webpack-plugin #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cspell.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"codecov",
"cmds",
"fnames",
"mimimizer",
"nocolor",
"oneline",
"preprocess",
Expand Down
32 changes: 16 additions & 16 deletions src/__tests__/__snapshots__/standalone.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * copy-webpack-plugin@X.X.X",
],
[
" * css-minimizer-webpack-plugin@X.X.X",
],
[
" * html-webpack-plugin@X.X.X",
],
Expand All @@ -93,6 +90,9 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * mini-svg-data-uri@X.X.X",
],
[
" * minimizer-webpack-plugin@X.X.X",
],
[
" * terser-webpack-plugin@X.X.X",
],
Expand Down Expand Up @@ -173,9 +173,6 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * copy-webpack-plugin@X.X.X",
],
[
" * css-minimizer-webpack-plugin@X.X.X",
],
[
" * html-webpack-plugin@X.X.X",
],
Expand All @@ -188,6 +185,9 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * mini-svg-data-uri@X.X.X",
],
[
" * minimizer-webpack-plugin@X.X.X",
],
[
" * terser-webpack-plugin@X.X.X",
],
Expand Down Expand Up @@ -266,9 +266,6 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * copy-webpack-plugin@X.X.X",
],
[
" * css-minimizer-webpack-plugin@X.X.X",
],
[
" * html-webpack-plugin@X.X.X",
],
Expand All @@ -281,6 +278,9 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * mini-svg-data-uri@X.X.X",
],
[
" * minimizer-webpack-plugin@X.X.X",
],
[
" * terser-webpack-plugin@X.X.X",
],
Expand Down Expand Up @@ -365,9 +365,6 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * copy-webpack-plugin@X.X.X",
],
[
" * css-minimizer-webpack-plugin@X.X.X",
],
[
" * html-webpack-plugin@X.X.X",
],
Expand All @@ -380,6 +377,9 @@ exports[`standalone should attempt to createStandalonePackageJson for multiple l
[
" * mini-svg-data-uri@X.X.X",
],
[
" * minimizer-webpack-plugin@X.X.X",
],
[
" * terser-webpack-plugin@X.X.X",
],
Expand Down Expand Up @@ -496,10 +496,10 @@ const setupDotenv = require('dotenv');
const { expand: dotenvExpand } = require('dotenv-expand');
const { merge } = require('webpack-merge');
const CopyPlugin = require('copy-webpack-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const HtmlReplaceWebpackPlugin = require('html-replace-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const MimimizerPlugin = require('minimizer-webpack-plugin');
const SvgToMiniDataURI = require('mini-svg-data-uri');
const TerserJSPlugin = require('terser-webpack-plugin');
const cssLoaderResolve = require.resolve('css-loader');
Expand Down Expand Up @@ -627,10 +627,10 @@ const setupDotenv = require('dotenv');
const { expand: dotenvExpand } = require('dotenv-expand');
const { merge } = require('webpack-merge');
const CopyPlugin = require('copy-webpack-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const HtmlReplaceWebpackPlugin = require('html-replace-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const MimimizerPlugin = require('minimizer-webpack-plugin');
const SvgToMiniDataURI = require('mini-svg-data-uri');
const TerserJSPlugin = require('terser-webpack-plugin');
const cssLoaderResolve = require.resolve('css-loader');
Expand Down Expand Up @@ -716,10 +716,10 @@ const setupDotenv = require('dotenv');
const { expand: dotenvExpand } = require('dotenv-expand');
const { merge } = require('webpack-merge');
const CopyPlugin = require('copy-webpack-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const HtmlReplaceWebpackPlugin = require('html-replace-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const MimimizerPlugin = require('minimizer-webpack-plugin');
const SvgToMiniDataURI = require('mini-svg-data-uri');
const TerserJSPlugin = require('terser-webpack-plugin');
const cssLoaderResolve = require.resolve('css-loader');
Expand Down Expand Up @@ -804,10 +804,10 @@ const setupDotenv = require('dotenv');
const { expand: dotenvExpand } = require('dotenv-expand');
const { merge } = require('webpack-merge');
const CopyPlugin = require('copy-webpack-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const HtmlReplaceWebpackPlugin = require('html-replace-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const MimimizerPlugin = require('minimizer-webpack-plugin');
const SvgToMiniDataURI = require('mini-svg-data-uri');
const TerserJSPlugin = require('terser-webpack-plugin');
const cssLoaderResolve = require.resolve('css-loader');
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/__snapshots__/wp.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ exports[`webpack should create a basic webpack config: basic configurations 1`]
{
"options": {
"test": {},
"extractComments": true,
"parallel": true,
"minimizer": {
"options": {
Expand Down
3 changes: 3 additions & 0 deletions src/__tests__/__snapshots__/wpConfigs.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,7 @@ exports[`webpackConfigs should return a production configuration object: product
{
"options": {
"test": {},
"extractComments": true,
"parallel": true,
"minimizer": {
"options": {
Expand Down Expand Up @@ -1160,6 +1161,7 @@ exports[`webpackConfigs should return a production configuration object: product
{
"options": {
"test": {},
"extractComments": true,
"parallel": true,
"minimizer": {
"options": {
Expand Down Expand Up @@ -1261,6 +1263,7 @@ exports[`webpackConfigs should return a production configuration object: product
{
"options": {
"test": {},
"extractComments": true,
"parallel": true,
"minimizer": {
"options": {
Expand Down
4 changes: 2 additions & 2 deletions src/standalone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,10 @@ const setupDotenv = require('dotenv');
const { expand: dotenvExpand } = require('dotenv-expand');
const { merge } = require('webpack-merge');
const CopyPlugin = require('copy-webpack-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const HtmlReplaceWebpackPlugin = require('html-replace-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const MimimizerPlugin = require('minimizer-webpack-plugin');
const SvgToMiniDataURI = require('mini-svg-data-uri');
const TerserJSPlugin = require('terser-webpack-plugin');
const cssLoaderResolve = require.resolve('css-loader');
Expand Down Expand Up @@ -327,11 +327,11 @@ const createStandalonePackageJson = (
'dotenv-webpack',
'webpack-merge',
'copy-webpack-plugin',
'css-minimizer-webpack-plugin',
'html-webpack-plugin',
'html-replace-webpack-plugin',
'mini-css-extract-plugin',
'mini-svg-data-uri',
'minimizer-webpack-plugin',
'terser-webpack-plugin',
'css-loader'
];
Expand Down
7 changes: 4 additions & 3 deletions src/wpConfigs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
const fs = require('fs');
const path = require('path');
const CopyPlugin = require('copy-webpack-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const HtmlReplaceWebpackPlugin = require('html-replace-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const MimimizerPlugin = require('minimizer-webpack-plugin');
const SvgToMiniDataURI = require('mini-svg-data-uri');
const TerserJSPlugin = require('terser-webpack-plugin');
const { babelLoaderResolve, babelPresetEnvResolve, cssLoaderResolve, tsLoaderResolve } = require('../lib/packages');
Expand Down Expand Up @@ -377,7 +377,7 @@ const development = (
* @param {object} settings
* @param {Function} settings.setupWebpackDotenvFilesForEnv
* @returns {{mode: string, devtool: undefined, output: {chunkFilename: string, filename: string},
* optimization: {minimize: boolean, runtimeChunk: string, minimizer: Array<any|CssMinimizerPlugin>,
* optimization: {minimize: boolean, runtimeChunk: string, minimizer: Array<any|MimimizerPlugin>,
* splitChunks: {chunks: string, cacheGroups: {vendor: {test: RegExp, chunks: string, name: string}}}},
* plugins: Array}}
*/
Expand All @@ -397,7 +397,8 @@ const production = (
new TerserJSPlugin({
parallel: true
}),
new CssMinimizerPlugin({
new MimimizerPlugin({
minify: MimimizerPlugin.cssnanoMinify,
minimizerOptions: {
preset: ['default', { mergeLonghand: false }]
}
Expand Down