Merged
Conversation
| chromeOptions.addArguments("--headless"); | ||
| chromeOptions.addArguments("--window-size=" + SeleniumHelper.readParameters("windowSize")); | ||
| // chromeOptions.addArguments("--headless"); | ||
| // chromeOptions.addArguments("--window-size=" + SeleniumHelper.readParameters("windowSize")); |
Contributor
Author
There was a problem hiding this comment.
Removed the comments.
Member
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Please add a PR description explaining the changes and update PR title.
| // chromeOptions.addArguments("--headless"); | ||
| // chromeOptions.addArguments("--window-size=" + SeleniumHelper.readParameters("windowSize")); | ||
| chromeOptions.addArguments("--headless=new"); | ||
| chromeOptions.addArguments("--window-size=1920,1080"); |
Member
There was a problem hiding this comment.
why are these not coming from properties class?
can we update the windowSize here :
itsmekumari
force-pushed
the
maxwindowfix
branch
from
83100f6 to
8f546f6
Compare
Contributor
Author
Added the PR description and title. |
itsankit-google
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the framework-level issue where the browser window was failing to scale correctly during execution.
Changes
Updated Chrome Headless Mode: Migrated from the legacy headless argument to --headless=new. This ensures better compatibility with the latest Chrome versions and to ensure consistency.
Corrected Resolution Format: Updated the configuration file to define screen dimensions using comma-separated values (1920,1080) instead of the 1920X1080 format to align with framework parsing requirements.
Removed the maximize() call. Since the window size is now correctly defined via config