Recursively inject on into combinator filter leaves #3931
+221
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryDefinition Previously, `normalizeQueryDefinition` only injected the `on` reference at the top-level filter. Combinator filters (not, any, every) left their inner leaf attribute filters without `on`, producing invalid filter structures. This adds a recursive walk that injects `on` into each leaf filter (eq, contains, range) that lacks one, while skipping type filters. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Preview deployments |
Host Test Results 1 files ± 0 1 suites ±0 2h 40m 4s ⏱️ + 56m 34s For more details on these failures, see this check. Results for commit 4452a15. ± Comparison against base commit bc47720. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
normalizeQueryDefinitionnow recursively walks the filter tree to injectoninto leaf attribute filters (eq,contains,range) that lack onenot,any,every) are traversed without injection at their leveltypefilters (self-scoping) are skippedonreferences on leaf filters are preservedFixes CS-10126
🤖 Generated with Claude Code