Remove some uses of ReturnTypeInfo#6577
Merged
geoffromer merged 2 commits intocarbon-language:trunkfrom Jan 13, 2026
Merged
Conversation
As with carbon-language#6572, this is a step toward supporting function calls that have arbitrary numbers of initializing returns.
zygoloid
approved these changes
Jan 11, 2026
| case SemIR::InitRepr::ByCopy: | ||
| case SemIR::InitRepr::Incomplete: | ||
| case SemIR::InitRepr::Abstract: | ||
| return_type_id = SemIR::ErrorInst::TypeId; |
Contributor
There was a problem hiding this comment.
Are we assuming here that CheckFunctionReturnPatternType would have diagnosed in this case? I worry that that coupling is a bit fragile, and could lead to using an ErrorInst without ever having produced an error diagnostic; would it work to instead make that function return an error type when it diagnoses an error, and propagate that to return_type_id here?
Contributor
Author
There was a problem hiding this comment.
Good idea. Done.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with #6572, this is a step toward supporting function calls that have arbitrary numbers of initializing returns.