Fix lowering of imported global variables.#6567
Merged
zygoloid merged 2 commits intocarbon-language:trunkfrom Jan 11, 2026
Merged
Fix lowering of imported global variables.#6567zygoloid merged 2 commits intocarbon-language:trunkfrom
zygoloid merged 2 commits intocarbon-language:trunkfrom
Conversation
* When a C++ static data member is imported, evaluate its address to a
constant like we would for a namespace-scope variable.
* When an imported variable is used in a way that doesn't require its
type to be complete, emit the variable with an opaque type instead
of skipping it (and potentially crashing later).
zygoloid
force-pushed
the
toolchain-var-template
branch
2 times, most recently
from
d61fbbb to
82ac7d0
Compare
zygoloid
force-pushed
the
toolchain-var-template
branch
from
82ac7d0 to
3759f1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constant like we would for a namespace-scope variable.
type to be complete, emit the variable with an opaque type instead
of skipping it (and potentially crashing later).